Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:reduntant message if only one network #3720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:reduntant message if only one network #3720

wants to merge 1 commit into from

Conversation

Ronexlemon
Copy link

@Ronexlemon Ronexlemon commented Oct 29, 2024 •
edited
Loading

Fixes: #3604

Description

Render checkout message to different network only when more than one contribution is made for different networks.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@Ronexlemon Ronexlemon requested review from a team as code owners October 29, 2024 13:29
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:32pm

@Ronexlemon Ronexlemon marked this pull request as draft October 29, 2024 13:39
@Ronexlemon Ronexlemon marked this pull request as ready for review October 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant message if only one network
1 participant
@Ronexlemon