Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize More Time button to display none #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

B0sh
Copy link

@B0sh B0sh commented Jan 18, 2023

Fixes an issue with the button showing when enableMoreTimeButton is true and the "Automatically show answer" setting is set to zero

Description

After disabling the more time button I noticed that it was still showing up - but only on some of my decks. After investigating in anki, I quickly realized that the culprit was wether there was a value in the "Automatically show answer" timer setting. When it's set to 0, the more timer button is showing up always regardless of the setting.

To address this, I hid the button by default. The idea is that when spdfShow is called, it will correctly reset the display value to show it. This does work with my anki settings, although I don't claim to be an expert on the platform. (only trying this on mac) Honestly, there's probably a code bug somewhere in here with the spdfShow/Hide functions, but I couldn't find it.

Thank you for this addon! Sorry I didn't want to see your extra button lol

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • I've read and understood the contribution guidelines
  • I've tested my changes against at least one of the following Anki builds:
    • Latest standard Anki 2.1 binary build (Anki 2.1.56)
    • Latest alternative Anki 2.1 binary build
  • I've tested my changes on at least one of the following platforms:
    • Linux, version:
    • Windows, version:
    • macOS, version: 13.1
  • My changes potentially affect non-desktop platforms, of which I've tested:
    • AnkiMobile, version:
    • AnkiDroid, version:
    • AnkiWeb

Fixes an issue with the button showing when enableMoreTimeButton is true and the "Automatically show answer" setting is set to zero
@glutanimate glutanimate self-requested a review February 1, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant