Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-5045 Raise various default max-connection config properties for the Elasticsearch backend #4347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HSEARCH-5045


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@marko-bekhta
Copy link
Member Author

I wonder whether it would make sense to make the total max connections some high number (e.g. Integer.MAX_VALUE) by default and let the per-route value keep things limited?

@yrodiere
Copy link
Member

I wonder whether it would make sense to make the total max connections some high number (e.g. Integer.MAX_VALUE) by default and let the per-route value keep things limited?

Seems to me this could lead to problems with large Elasticsearch cluster? I.e. with a 20-node cluster, one app instance could end up opening 400 connections...

@marko-bekhta
Copy link
Member Author

good point! 😃 thanks!

Copy link

sonarcloud bot commented Oct 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants