fix: remove duplicateIds on unique assets #13752
Open
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
reviewed
Oct 26, 2024
web/src/routes/(user)/utilities/duplicates/[[photos=photos]]/[[assetId=id]]/+page.ts
Outdated
Show resolved
Hide resolved
web/src/routes/(user)/utilities/duplicates/[[photos=photos]]/[[assetId=id]]/+page.ts
Outdated
Show resolved
Hide resolved
web/src/routes/(user)/utilities/duplicates/[[photos=photos]]/[[assetId=id]]/+page.ts
Outdated
Show resolved
Hide resolved
|
Would this be better to do on the server side? It'd save a bunch of round trips etc. |
|
Yeah, that makes sense to me. |
bo0tzz
approved these changes
Oct 27, 2024
| @@ -15,8 +15,24 @@ import { usePagination } from 'src/utils/pagination'; | |||
| export class DuplicateService extends BaseService { | |||
| async getDuplicates(auth: AuthDto): Promise<DuplicateResponseDto[]> { | |||
| const res = await this.assetRepository.getDuplicates({ userIds: [auth.user.id] }); | |||
|
|
|||
| return mapDuplicateResponse(res.map((a) => mapAsset(a, { auth, withStack: true }))); | |||
| const uniqueAssetIds: string[] = []; | |||
There was a problem hiding this comment.
Naming nitpick: These aren't necessarily unique, right (more accurately, all assetIds are unique)? Not sure what a better name would be though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11637
Issue Overview
A bug was identified in the review duplicates utility where, after manually deleting a duplicate image, the corresponding group was still displayed with a single leftover image.
Changes
We validate the duplicates in duplicates utility page by checking if each duplicate set has atleast 2 assets. If not we update the assets to remove duplicates ids from them and do not show them on the page.