After 0.17.0: Remove CUI #8384
Draft
After 0.17.0: Remove CUI #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmair
added
user interface
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
==========================================
- Coverage 84.42% 79.21% -5.21%
==========================================
Files 1167 1168 +1
Lines 53057 57363 +4306
Branches 1947 1947
==========================================
+ Hits 44791 45438 +647
- Misses 7780 11441 +3661
+ Partials 486 484 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
That's a lot of code removed :) |
|
@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CUI and adjacent helpers that are no longer required.
Part of the preparation for 1.0 as listed in the blog.