-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After 0.17.0: Remove CUI #8384
base: master
Are you sure you want to change the base?
After 0.17.0: Remove CUI #8384
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
==========================================
- Coverage 84.42% 79.21% -5.21%
==========================================
Files 1167 1168 +1
Lines 53057 57363 +4306
Branches 1947 1947
==========================================
+ Hits 44791 45438 +647
- Misses 7780 11441 +3661
+ Partials 486 484 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That's a lot of code removed :) |
@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests |
This PR removes CUI and adjacent helpers that are no longer required.
Part of the preparation for 1.0 as listed in the blog.