-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add W=1 to Makefile #64
Add W=1 to Makefile #64
Conversation
Just one thought: should we add The downside I see in forcing the checks in the Makefile is that it'll affect all users of the yet-out-of-tree drivers. Enabling |
Yeah, I think that's the way to go. Users should be able to compile and insert regardless of us missing an extended declaration or something. |
Actually, to clarify, on But, still, that's not the default in C or kernel land... |
Me too, but...
That's the thing, I've seen drivers in hwmon that fail with W=1 with today's tree. Arguably, if W=1 is in CI, then the code here should pass it, unless the definition of it changes? C=1 should be left to CI, I think. Sorry for the jumbled comment, I'll think more about it, but I'd definitely like to have W=1 in CI at least. |
Whoops, should have checked first before making this assumption. Here W=1 just gives a warning, while in the kernel it stops the compilation. In that case, as you said, I think it's OK to turn it on for everyone (as it's useful to have during development), but CI would need to treat the warnings it gives as errors, so there's still a distinction. I'll look into that. |
Signed-off-by: Aleksa Savic <[email protected]>
Signed-off-by: Aleksa Savic <[email protected]>
Signed-off-by: Aleksa Savic <[email protected]>
92b739a
to
166a13e
Compare
Here's how this looks like:
sparse seems to generate a lot of warnings that have nothing to do with the drivers in here, so it looks like I'll have to extend the problem matcher to catch messages related to code from this repo. |
If I'm not mistaken, this can be merged as is. Or do you prefer to first improve the problem matcher? |
Let's merge it as is and I'll deal with the problem matcher later (I'm somewhat short on time right now). |
Related to #60. Add W=1 to Makefile.
Marking as a draft because I'd like to also add C=1, but I had to install sparse myself, so I need to investigate the Github CI.