Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLOfflinePackObserver #15851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mateuszmackowiak
Copy link

The main issue for us is that we do not receive a callback on when the offline maps states are loaded.
When referencing [MGLOfflineStorage sharedOfflineStorage] for the first time it calls internally reloadPacks method witch is asynchronous with no callback.
I know that we can observer the packages by KVO and the for all packages we can request refreshProgress and then once again observer with KVO the state but synchronising it all is problematic and without proper memory management and removal of kvo observers it will crush.

I have made a pull request that extends the MGLOfflineStorageDelegate with an optional method - (void)didReloadPackagesForOfflineStorage:(MGLOfflineStorage *)storage; that should inform clearly what was loaded.

@mateuszmackowiak mateuszmackowiak requested a review from a team October 24, 2019 09:59
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline labels Oct 28, 2019
@julianrex
Copy link
Contributor

@mateuszmackowiak thanks for the PR - we will review. FYI we're in the process of transitioning the iOS/macOS code to a separate repo, so please bear with us.

@chloekraw chloekraw added this to the release-t milestone Nov 4, 2019
@julianrex
Copy link
Contributor

julianrex commented Mar 9, 2020

Apologies for the delay - @mateuszmackowiak are you still interested in this feature? If so, can you please recreate it in http://github.com/mapbox/mapbox-gl-native-ios? /cc @1ec5

Closing this as not-actionable in this repo.

Update: We will create a new PR on your behalf.

@julianrex julianrex closed this Mar 9, 2020
@julianrex julianrex reopened this Mar 9, 2020
@knov knov removed request for a team, 1ec5 and fabian-guerra March 30, 2020 18:34
@mateuszmackowiak
Copy link
Author

Hi, I don't see the PR in the new repo? Should I create it?

@knov knov removed this from the release-unicorn milestone Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants