-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MediaRecorder preferences #99
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mux/stream-new/2vYsoTKE5iBuuAHd2PnZKYPZuBqd |
I'm curious (this is outside my wheelhouse) - why is opus a last-resort audio codec? (or is it implied by the other codec options?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question -- assuming that is addressed then go ahead and 🚢 , all the other changes look 👌🏼
* MediaRecorder.isTypeSupported is not a thing in safari, | ||
* good thing safari supports the preferredOptions | ||
*/ | ||
if (typeof MediaRecorder.isTypeSupported === 'function') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to get rid of this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://caniuse.com/mdn-api_mediarecorder_istypesupported
Supported in all but IE
@davekiss is this good to merge? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dylanjha This should be g2g, can you try a recording on your end to sanity check? |
After consulting with @philcluff @gkatsev and @cjpillsbury -- this is the consensus for the recommended
mimeType
stack for MediaRecorder for our use case.vp9