AWS: switch from containerProperties to ecsProperties #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pditommaso
reviewed
Oct 11, 2024
plugins/nf-amazon/src/main/nextflow/cloud/aws/batch/AwsBatchHelper.groovy
Outdated
Show resolved
Hide resolved
tom-seqera
force-pushed
the
5096-aws-ecs-properties
branch
from
28c6034
to
4f8b192
Compare
pditommaso
reviewed
Oct 11, 2024
| @@ -181,7 +181,9 @@ class AwsBatchHelper { | |||
| final response = batchClient.describeJobs(request) | |||
| if( response.jobs ) { | |||
| final detail = response.jobs[0] | |||
| return detail.container.logStreamName | |||
| return detail.ecsProperties?.taskProperties[0]?.containers[0]?.logStreamName | |||
There was a problem hiding this comment.
Not sure if with an empty list [0] returns IndexOutOfBoundException, may be it's better to wrap this (and other similar) in helper method and use if try/catch(Exception) returning a null if something is going wrong
There was a problem hiding this comment.
Just checked and it seems emptyList[0] returns null so I think that's fine. Unfortunately obj.nullList[0] throws a NPE.
This is a bit awkward, but would work:
detail.ecsProperties?.taskProperties?[0]?.containers?[0]?.logStreamNameThere was a problem hiding this comment.
Too ugly, make sense to have little helper method
Signed-off-by: Tom Sellman <[email protected]>
tom-seqera
force-pushed
the
5096-aws-ecs-properties
branch
from
4f8b192
to
418cf0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5096
Use EcsProperties instead of ContainerProperties to configure AWS Batch jobs.
See AWS docs