-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing trace record meta info in the task context #5402
Exposing trace record meta info in the task context #5402
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Embarrassingly simple! tagging @luisas for visibility |
what if accessing |
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
I though it was working in a similarly as in the directives, but it fails with No such variable. I need to add a default trace value, as null or empty TraceRecord. In the first case, users case easily check if there is no previous trace as in the example. @pditommaso what do you think? |
I have done an update setting the trace record in |
modules/nextflow/src/main/groovy/nextflow/processor/TaskPollingMonitor.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
…sor.groovy [ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
…rDie Signed-off-by: jorgee <[email protected]>
1e4c613
to
19289c0
Compare
…nfo-in-the-task-context
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions to shorten sentences.
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
…sor.groovy Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
When retry trace record is generated and included in the task context with variable
trace
In the first attempt, trace is null. I tried to set a partial trace record for the first attempt generating the trace record just after the creation of the TaskHandler. But the evaluation of the directives is executed before the generation of the first TaskHandler at executor.submit. So, the value was null. One alternative, could be to move the generation of the trace record to the TaskRun but it implies to move some data such as the status, start and stop time in the TaskRun.
Included a suggestion for documentation