Exposing trace record meta info in the task context #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Embarrassingly simple! tagging @luisas for visibility |
|
what if accessing |
pditommaso
reviewed
Oct 15, 2024
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
I though it was working in a similarly as in the directives, but it fails with No such variable. I need to add a default trace value, as null or empty TraceRecord. In the first case, users case easily check if there is no previous trace as in the example. @pditommaso what do you think? |
bentsherman
reviewed
Oct 16, 2024
|
I have done an update setting the trace record in |
pditommaso
reviewed
Oct 21, 2024
modules/nextflow/src/main/groovy/nextflow/processor/TaskPollingMonitor.groovy
Outdated
Show resolved
Hide resolved
pditommaso
reviewed
Oct 21, 2024
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
…sor.groovy [ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
…rDie Signed-off-by: jorgee <[email protected]>
jorgee
force-pushed
the
5396-consider-exposing-trace-record-meta-info-in-the-task-context
branch
from
1e4c613
to
19289c0
Compare
…nfo-in-the-task-context
pditommaso
reviewed
Oct 22, 2024
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Oct 22, 2024
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Oct 22, 2024
Signed-off-by: Paolo Di Tommaso <[email protected]>
christopher-hakkaart
requested changes
Oct 22, 2024
pditommaso
reviewed
Oct 22, 2024
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
…sor.groovy Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
deleted the
5396-consider-exposing-trace-record-meta-info-in-the-task-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retry trace record is generated and included in the task context with variable
traceIn the first attempt, trace is null. I tried to set a partial trace record for the first attempt generating the trace record just after the creation of the TaskHandler. But the evaluation of the directives is executed before the generation of the first TaskHandler at executor.submit. So, the value was null. One alternative, could be to move the generation of the trace record to the TaskRun but it implies to move some data such as the status, start and stop time in the TaskRun.
Included a suggestion for documentation