Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov to repo #25

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Add codecov to repo #25

merged 4 commits into from
Oct 31, 2023

Conversation

MillironX
Copy link
Member

Background

This is phase one of my four-part plan to fix the gripes with this action

This PR

Add code coverage metrics (so we know where we came from)

Unit testing API calls is hard, especially when the point of this action is to resolve version numbers from an API that are constantly changing. I have working code that can make the entire action unit-testable, but I want to establish a baseline before I submit that.

Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Let's call it v2.0.0 when this moves to nf-core actions. I've been wanting to do something like that after seeing https://github.com/emacscollective/workflows

@edmundmiller edmundmiller added this to the 2.0.0 milestone Oct 31, 2023
@MillironX MillironX merged commit d736e95 into nf-core:master Oct 31, 2023
16 checks passed
@MillironX MillironX deleted the feature/coverage branch October 31, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants