Skip to content

Commit

Permalink
Merge pull request #3205 from mashehu/fix-ignore-params
Browse files Browse the repository at this point in the history
Use correct key for parsing `defaultIgnoreParams`
  • Loading branch information
mashehu authored Oct 9, 2024
2 parents 61dec48 + bf2c6bb commit 530b24a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions nf_core/modules/lint/main_nf.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ def check_process_section(self, lines, registry, fix_version, progress_bar):
continue
try:
container_url = "https://" + urlunparse(url) if not url.scheme == "https" else urlunparse(url)
log.debug(f"Trying to connect to URL: {container_url}")
response = requests.head(
container_url,
stream=True,
Expand Down
3 changes: 2 additions & 1 deletion nf_core/pipelines/schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ def _update_validation_plugin_from_config(self) -> None:
conf.get("validation.help.fullParameter", "helpFull"),
conf.get("validation.help.showHiddenParameter", "showHidden"),
] # Help parameter should be ignored by default
ignored_params_config = conf.get("validation", {}).get("defaultIgnoreParams", [])
ignored_params_config = conf.get("validation.defaultIgnoreParams", [])
if len(ignored_params_config) > 0:
log.debug(f"Ignoring parameters from config: {ignored_params_config}")
ignored_params.extend(ignored_params_config)
self.ignored_params = ignored_params
self.schema_draft = "https://json-schema.org/draft/2020-12/schema"
Expand Down

0 comments on commit 530b24a

Please sign in to comment.