Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Bump support for Node 20+ #1643

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[IMP] Bump support for Node 20+ #1643

merged 1 commit into from
Oct 9, 2024

Conversation

rfr-odoo
Copy link
Contributor

@rfr-odoo rfr-odoo commented Oct 7, 2024

This commit bump the support for Node 20+.

@rfr-odoo rfr-odoo self-assigned this Oct 7, 2024
@rfr-odoo rfr-odoo force-pushed the master-node-18-rfr branch 4 times, most recently from a1c2e01 to be58efe Compare October 8, 2024 08:00
@rfr-odoo
Copy link
Contributor Author

rfr-odoo commented Oct 8, 2024

@sdegueldre @ged-odoo
I have made this PR but i don't know if it's correct to do a testIf to handle the différence in error handling of Node 18 vs Node 20+.

If you have another idea let me know

This PR should close the issue #1540

@rfr-odoo rfr-odoo marked this pull request as ready for review October 8, 2024 09:33
This commit bump the support for Node 20+.
@rfr-odoo rfr-odoo changed the title [IMP] Bump support for Node 18+ [IMP] Bump support for Node 20+ Oct 9, 2024
@rfr-odoo
Copy link
Contributor Author

rfr-odoo commented Oct 9, 2024

After further discussion with @ged-odoo
To simplify the commit we can avoid using Node 18 as it's only used for testing.

@ged-odoo ged-odoo merged commit 3e11fe6 into master Oct 9, 2024
2 checks passed
@ged-odoo ged-odoo deleted the master-node-18-rfr branch October 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants