Address review comments.

oneapi-src · Oct 28, 2024 · 3a60d1a · 3a60d1a
1 parent 5067fc3
commit 3a60d1a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/examples/common/utility/utility.hpp b/examples/common/utility/utility.hpp
@@ -377,10 +377,7 @@ class measurements {
     }
     double computeRelError() {
         // Accumulate the total duration in microseconds using std::accumulate with a lambda function
-        if (0 == _time_intervals.size()) {
-            std::cout << "No time samples collected \n";
-            return 0;
-        }
+        assert(0 != _time_intervals.size());
         auto total_duration = std::accumulate(
             _time_intervals.begin(),
             _time_intervals.end(),
@@ -391,12 +388,12 @@ class measurements {
                                    interval.second - interval.first)
                                    .count();
             });
-        long long averageTimePerFrame = total_duration / _time_intervals.size();
-        long long sumOfSquareDiff = 0;
+        unsigned long long averageTimePerFrame = total_duration / _time_intervals.size();
+        unsigned long long sumOfSquareDiff = 0;
         std::for_each(_time_intervals.begin(),
                       _time_intervals.end(),
                       [&](const std::pair<time_point, time_point>& interval) {
-                          long long duration =
+                          unsigned long long duration =
                               std::chrono::duration_cast<std::chrono::microseconds>(
                                   interval.second - interval.first)
                                   .count();

diff --git a/examples/parallel_for/seismic/main.cpp b/examples/parallel_for/seismic/main.cpp
@@ -99,7 +99,7 @@ int main(int argc, char *argv[]) {
             std::cout << "Substituting 1000 for unlimited frames because not running interactively"
                       << "\n";
         }
-        // TODO : Extend utility::cli_argument_pack()  toallow specifying the default value.
+        // TODO : Extend utility::cli_argument_pack() to allow specifying the default value.
         if (options.numberofIterations == 0) {
             options.numberofIterations = 10;
             std::cout << "Setting the number of iterations = 10 default"