Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added runners for enabling concurrent segment search via settings #591

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jul 23, 2024

Description

Added EnableConcurrentSegmentSearch runner, this will be used in semantic search workloads like https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/noaa_semantic_search or one that is in PR opensearch-project/opensearch-benchmark-workloads#342

Issues Resolved

building block for opensearch-project/opensearch-benchmark-workloads#341

Testing

  • New functionality includes testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski force-pushed the add_operation_enabled_concurrent_segment_search branch from afc6496 to d25b145 Compare July 23, 2024 20:32
@@ -2696,3 +2697,17 @@ async def __call__(self, opensearch, params):

def __repr__(self, *args, **kwargs):
return "deploy-ml-model"

class EnableConcurrentSegmentSearch(Runner):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: What do you think about naming as UpdateConcurrentSegmentSearchClusterSettings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, makes sense if we're adding the slice count param

@VijayanB
Copy link
Member

@martin-gaievski Do you have plan to add slice settings as well?

@martin-gaievski
Copy link
Member Author

@martin-gaievski Do you have plan to add slice settings as well?

do you mean setting search.concurrent.max_slice_count? I can add it to, it can be operation UpdateConcurrentSegmentSearchClusterSettings and two params: enable and max_slice_count.

Copy link
Member

@VijayanB VijayanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-gaievski martin-gaievski force-pushed the add_operation_enabled_concurrent_segment_search branch from fdb3cb0 to 034def4 Compare July 23, 2024 22:45
@martin-gaievski martin-gaievski force-pushed the add_operation_enabled_concurrent_segment_search branch from 034def4 to 41b0429 Compare July 23, 2024 23:04
@VijayanB
Copy link
Member

@IanHoang @gkamat Can you take a look at this PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants