Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about integrating APIs with security #1460

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

ohltyler
Copy link
Member

Signed-off-by: Tyler Ohlsen [email protected]

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Documentation

  2. Github Issue # or road-map entry, if available:
    N/A

  3. Description of changes:
    Adding a section in the README with instructions on how to onboard/integrate new APIs with security.

  4. Why these changes are required?
    For consistency and faster development of different plugins wanting to integrate new or existing APIs with security.

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
    N/A

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    N/A

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
    N/A

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)
    N/A

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler requested a review from a team September 24, 2021 15:51
@davidlago davidlago added the documentation For code documentation/ javadocs/ comments / readme etc.. label Nov 12, 2021
@davidlago
Copy link

davidlago commented Feb 13, 2022

Thanks for the PR @ohltyler. Apologies for the long delay in the review... especially as we've since updated the README :( Could you please update to move section down right before the Contributing header as git auto-resolving the conflicts is placing it at the very beginning? Thanks!

@ohltyler
Copy link
Member Author

Thanks for the PR @ohltyler. Apologies for the long delay in the review... especially as we've since updated the README :( Could you please update to move section down right before the Contributing header as git auto-resolving the conflicts is placing it at the very beginning? Thanks!

Done!

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #1460 (2c7eb61) into main (61869e7) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1460      +/-   ##
============================================
- Coverage     64.66%   64.62%   -0.05%     
+ Complexity     3220     3218       -2     
============================================
  Files           247      247              
  Lines         17351    17351              
  Branches       3082     3082              
============================================
- Hits          11220    11213       -7     
- Misses         4581     4588       +7     
  Partials       1550     1550              
Impacted Files Coverage Δ
...ecurity/configuration/ConfigurationRepository.java 73.07% <0.00%> (-2.20%) ⬇️
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61869e7...2c7eb61. Read the comment docs.

davidlago
davidlago previously approved these changes Feb 13, 2022
@cliu123
Copy link
Member

cliu123 commented Apr 7, 2022

Are we having similar content in all plugins README? If so, is there any issue tracking this effort to apply these documentation changes consistently on all plugins?

@ohltyler
Copy link
Member Author

I don't believe this is documented in any plugins. The idea of adding it here, is so all plugins can have a central place to refer to.

peternied
peternied previously approved these changes Apr 25, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good starting point, lets add it for now and then we can figure out the best mechanism to get this information out.

@ohltyler Could you create a follow up issue in the plugins repo to track centralized practices / tutorial / documentation that would make sense to link this to?

@ohltyler
Copy link
Member Author

I think this is a good starting point, lets add it for now and then we can figure out the best mechanism to get this information out.

@ohltyler Could you create a follow up issue in the plugins repo to track centralized practices / tutorial / documentation that would make sense to link this to?

I like this idea, created a tracking issue in opensearch-plugins and assigned myself - opensearch-project/opensearch-plugins#146

@peternied
Copy link
Member

@ohltyler Looks like we need this change to be rebased so it can pass all of our new CI systems, could you do that so we can merge?

- [Encryption](#encryption)
- [Authentication](#authentication)
- [Access control](#access-control)
- [Audit/Compliance logging](#auditcompliance-logging)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audit/compliance-logging instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? This is auto-generated with prettier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format auditcompliance-logging looks different from other items. If only this format will work, then let's go with it.

@cliu123 cliu123 merged commit 850e202 into opensearch-project:main Apr 28, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation For code documentation/ javadocs/ comments / readme etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants