Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floatFragmentTextures that is always return undefined on latest ThreeJS package #10

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ammein
Copy link
Collaborator

@ammein ammein commented Sep 12, 2024

Refer to #9 .

if (renderer.extensions.has("OES_texture_float")){
    this.floatType = FloatType
} else if (renderer.extensions.has("OES_texture_half_float")) {
    this.floatType = HalfFloatType
} else {
    this.floatType = UnsignedByteType
}
  • Update all examples packages to use latest ThreeJS and React packages so that it can be running smoothly.
  • Fix typings issues using latest threejs typescript package.

Once you confirm this repo and merge, don forget to run this command at the root folder to publish to npm package:

# Run Release script from root
yarn release

…rn undefined. Fix it by using UnsignedByteType for default
…act environment for now. Perhaps it will be added in the future if someone requested it.
@patriciogonzalezvivo
Copy link
Owner

thank you @ammein !

@patriciogonzalezvivo patriciogonzalezvivo merged commit 4bd9a8b into patriciogonzalezvivo:main Sep 13, 2024
1 check passed
@patriciogonzalezvivo
Copy link
Owner

(base) [0.824s][main][~/Desktop/glsl-pipeline]$ yarn release
yarn run v1.22.19
$ chmod +x ./scripts/release.sh && ./scripts/release.sh
$ preconstruct build
🎁 info building bundles!
🎁 success built bundles!
$ /home/patricio/Desktop/glsl-pipeline/node_modules/.bin/changeset publish
🦋  info npm info glsl-pipeline
🦋  info glsl-pipeline is being published because our local version (3.0.0) has not been published on npm
🦋  info Publishing "glsl-pipeline" at "3.0.0"
🦋  info This operation requires a one-time password from your authenticator.
🦋  Enter one-time password: · 271518
🦋  success packages published successfully:
🦋  [email protected]
🦋  Creating git tag...
🦋  New tag:  [email protected]
Done in 34.28s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants