Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment wave5 garbage data #474

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Comment wave5 garbage data #474

merged 2 commits into from
Oct 7, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Oct 6, 2024

Fixes #402

@Rangi42 Rangi42 requested a review from dannye October 6, 2024 00:20
@Rangi42
Copy link
Member Author

Rangi42 commented Oct 6, 2024

I'd like to also list which songs/SFX use which data, but am not sure which ones do. music/lavender.asm uses audio 1, music/pokemontower.asm uses audio 3, and those are the only files that do note_type _, _, 5 in Ch3 or Ch7; but are thee other ways to change the wave pattern?

@Rangi42 Rangi42 merged commit 8355771 into pret:master Oct 7, 2024
1 check passed
@Rangi42 Rangi42 deleted the wave5 branch October 7, 2024 16:04
PokefanMarcel pushed a commit to PokefanMarcel/pokered that referenced this pull request Oct 18, 2024
@Rangi42 @PokefanMarcel
Comment wave5 garbage data (pret#474)
ac33c64 
Also mention songs that use which wave5 data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannye dannye Awaiting requested review from dannye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment the wave pattern 5 data that happens to be read from SFX
1 participant
@Rangi42