Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disclaimer height with breakpoint #228

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix disclaimer height with breakpoint #228

wants to merge 10 commits into from
+2 −3

Conversation

hardingjam
Copy link
Collaborator

@hardingjam hardingjam commented Oct 24, 2024 •
edited
Loading

Motivation

Solution

Screen.Recording.2024-10-24.at.18.34.30.mov

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardingjam hardingjam self-assigned this Oct 24, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rain-frame ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 3:29pm

@hardingjam hardingjam linked an issue Oct 24, 2024 that may be closed by this pull request
Disclaimer height issue #18
Open
@hardyjosh
Copy link
Contributor

this doesn't look quite right on desktop anymore

image

hardyjosh
hardyjosh requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@hardyjosh hardyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix this
image

should look as it did before

@hardingjam
Copy link
Collaborator Author

should look as it did before

image

This is what it looks like on main - is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@hardingjam hardingjam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disclaimer height issue
2 participants
@hardingjam @hardyjosh