-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixings for windows (Update thread_priority.cpp #170) #179
Fixings for windows (Update thread_priority.cpp #170) #179
Conversation
Adding implementation for build on windows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 8 8
Lines 341 341
Branches 62 62
=======================================
Hits 257 257
Misses 50 50
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for breaking this. Are you familiar with windows CI pipelines and want to contribute one?
I have some few knowledge about CI on Windows, although I don't have extensive experience in this area. However, I’m eager to contribute! This isn't my main account; you can find me more actively participating under @GilmarCorreia . I'm currently working on creating a CI to compile all ROS desktop components on Windows with Python 3.10 to ensure compatibility with IsaacSim as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mightn't work as when you link against it, it will complain about missing reference to the method lock_memory defined in the .hpp
Could you take a look at #180 and let us know what you think?
@SENAI-GilmarCorreia does this entry bother you? Line 24 in 11af426
|
@saikishor, I don’t have any issues with this dependency. |
Thank you for clarifying |
closing in favor of #180 ? |
Hello ROS Developers,
After the last update provided by #175 and #170, the new includes were not available to windows. As I'm working on this on windows I provided a quick fix to solve this problem.
I really don't like my proposed solution, but we can considered as a hot fix for windows users.