Add traits PartialEq and Eq to EventListenerOptions, and EventListenerPhase #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranile
requested changes
Aug 7, 2023
Philipp-M
force-pushed
the
add-eq-to-event-listener-options
branch
from
7a74821
to
6ec1b2a
Compare
|
Like this? |
Philipp-M
force-pushed
the
add-eq-to-event-listener-options
branch
from
6ec1b2a
to
853bbb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to compare the options of an event listener, I don't think it hurts adding support for
PartialEqandEqfor the relevant types.