Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the job if no warnings #13

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Pass the job if no warnings #13

merged 1 commit into from
Oct 24, 2024

Conversation

shmokmt
Copy link
Owner

@shmokmt shmokmt commented Oct 24, 2024

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

docker_build_jq='{

@shmokmt shmokmt force-pushed the pass-if-no-warnings branch 4 times, most recently from 823ba0d to 28707df Compare October 24, 2024 04:13
@@ -47,14 +47,23 @@ diagnostics: .warnings | map({
})
}'

docker_files=$(git ls-files --exclude='*Dockerfile*' --ignored --cached)
docker_files=($(git ls-files --exclude='*Dockerfile*' --ignored --cached))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2207

@shmokmt shmokmt marked this pull request as ready for review October 24, 2024 04:30
@shmokmt shmokmt merged commit a4c066c into master Oct 24, 2024
3 checks passed
@shmokmt shmokmt deleted the pass-if-no-warnings branch October 24, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant