Revert "skip DSL error tests"

[shogo82148]

This reverts commit e3e4555.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for invalid DSL usage by reintroducing test cases to ensure accurate error reporting.
  • Enhanced validation for function calls with incompatible argument types, ensuring proper identification of type mismatches.

[coderabbitai]

Walkthrough

This update revitalizes the test cases for DSL error handling in runner_test.go. It removes unnecessary commented-out code and reintroduces two critical test contexts: one for invalid DSL usage and another for type mismatch in function calls. These changes enhance the clarity and robustness of error reporting mechanisms, ensuring the system effectively identifies and handles errors.

Changes

File	Change Summary
dslengine/runner_test.go	Restructured test cases by removing commented-out code; reintroduced tests for invalid DSL usage and function call type mismatches.

Poem

🐰 In the land of code so bright,
Tests return, a joyful sight!
Errors caught with care and grace,
Validations now take their place.
Hooray for fixes, let’s all cheer,
Robust DSL, we hold dear! 🥕

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9090727 and 56567ff.

Files selected for processing (1)

• dslengine/runner_test.go (1 hunks)

Additional comments not posted (2)

dslengine/runner_test.go (2)

103-123: LGTM! Reintroduced test context for invalid DSL usage is well-defined.

The context correctly sets up an invalid DSL scenario and verifies the expected error message and details.

---

125-145: LGTM! Reintroduced test context for type mismatch in DSL function calls is well-defined.

The context correctly sets up a scenario with an invalid argument type and verifies the expected error message and details.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 56567ff and ae1fc2c.

Files selected for processing (1)

• dslengine/runner_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• dslengine/runner_test.go