-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for reading the model dump #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irina Khismatullina <[email protected]>
vmarkovtsev
requested changes
Oct 16, 2019
vmarkovtsev
requested changes
Oct 17, 2019
Signed-off-by: Irina Khismatullina <[email protected]>
irinakhismatullina
force-pushed
the
read
branch
from
October 17, 2019 08:57
fde8c18
to
62d0680
Compare
Signed-off-by: Irina Khismatullina <[email protected]>
Signed-off-by: Irina Khismatullina <[email protected]>
vmarkovtsev
requested changes
Oct 17, 2019
irinakhismatullina
force-pushed
the
read
branch
from
October 22, 2019 08:48
39b93ca
to
af61fcb
Compare
irinakhismatullina
force-pushed
the
read
branch
2 times, most recently
from
October 22, 2019 09:03
1c44603
to
4bbb95e
Compare
vmarkovtsev
requested changes
Oct 22, 2019
go.sum
Outdated
@@ -0,0 +1,12 @@ | |||
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I just add it to gitignore? It slips in when I forget to remove it
Signed-off-by: Irina Khismatullina <[email protected]>
irinakhismatullina
force-pushed
the
read
branch
from
October 22, 2019 09:56
4bbb95e
to
5a79713
Compare
vmarkovtsev
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function reads BPE model dump in a format used in YouTokenToMe.