Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Move Column logic from Twig to PHP #861

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stephanvierkant
Copy link
Collaborator

Currently Twig is used to render the options. I think Twig shouldn't be used like this: this is where PHP should be used instead. Related to #819. This is just a 'proof of concept', so please share your thoughts about this.

Not the most important or this idea, but the HTML will look better too:
screenshot_20181218_193121

@stephanvierkant stephanvierkant added compatibility Request for Comments If you care about this bundle, please share your thoughts about this issue. refactoring Help wanted labels Dec 18, 2018
@Seb33300
Copy link
Collaborator

I agree, options should not be generated manually from twig.

You only did it for columns options but I think this should be done for everything. (wip so I guess this is planned?)

I think:

  • getTwigOptions should be renamed by getOptions.
  • twig templates and getOptionsTemplate method should be removed

@stephanvierkant
Copy link
Collaborator Author

I've changed the method name and removed getOptionsTemplate

Since ColumnInterface has been changed, this is a BC-breaking change.

@stephanvierkant stephanvierkant changed the title [wip] Move business logic from Twig to PHP Move Column logic from Twig to PHP Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BC-break refactoring Request for Comments If you care about this bundle, please share your thoughts about this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants