Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for luzrain/workerman-bundle #1536

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

luzrain
Copy link
Contributor

@luzrain luzrain commented Aug 24, 2023

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 24, 2023 13:21
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1536/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1536/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'luzrain/workerman-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled August 24, 2023 13:22

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 24, 2023 13:23
auto-merge was automatically disabled August 24, 2023 13:26

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 24, 2023 13:27
auto-merge was automatically disabled August 24, 2023 13:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 24, 2023 13:32
@luzrain luzrain disabled auto-merge August 24, 2023 13:37
@luzrain
Copy link
Contributor Author

luzrain commented Aug 24, 2023

Check failed because bundle requires implementation of the psr7/psr17 and depends only on PSR abstractions. User should manually install one of them, nyholm/psr7 as an example.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 30, 2023 12:37
@symfony-recipes-bot symfony-recipes-bot merged commit c4e97df into symfony:main Aug 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants