Remove content view version from environments if empty #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
commented
Aug 26, 2021
| current_environment_ids = {environment['id'] for environment in content_view_version['environments']} | ||
|
|
||
| for environment_id in current_environment_ids: | ||
| response = module.resource_action('content_views', 'remove_from_environment', params={'id': content_view['id'], 'environment_id': environment_id}) |
There was a problem hiding this comment.
On newer releases of Katello, I think this can be done in one call via:
response = module.resource_action('content_views_versions', 'remove_from_environments', params={'id': content_view['id'], 'environment_ids': current_environment_ids})
There was a problem hiding this comment.
Newer is 4.0+? If there is a possible perfomance gain, I'd be in favor of an if/else?
BTW, the linter says this line is too damn long (170>160 chars) ;)
evgeni
reviewed
Aug 27, 2021
| force=module.foreman_params['force_promote'], | ||
| force_yum_metadata_regeneration=module.foreman_params['force_yum_metadata_regeneration'], | ||
| ) | ||
| if module.foreman_params['lifecycle_environments'] == [] and content_view_version['environments']: |
There was a problem hiding this comment.
Should this happen only if the user says [] or always when the list doesn't match?
The later has some complications as we never list Library and I think the current user expectation is "promote to these envs, don't touch the others"?
ehelms
force-pushed
the
add-env-cleanup
branch
from
8acdd61
to
741fdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably needs some testing added, did not want to forget about this change I encountered doing some cleanup tasks.