Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename platform config iphone to ios #669

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

cb1kenobi
Copy link
Contributor

When running ti build without any args, it would prompt for the platform, but then it wouldn't properly load the platform config because the property was callled iphone, yet the prompt value for iOS was ios (derived from ti.targetPlatforms in node-titanium-sdk).

The second problem is the prompted platform value was not being stored back into Commander. The platform prompt happens during the first parse. When calling Commander to re-parse with the new knowledge, it would think --platform was not set and then overwrite the previously prompted platform with undefined causing platform to be prompted again.

@cb1kenobi cb1kenobi changed the title fix: Rename platform config 'iphone' to 'ios' fix: Rename platform config iphone to ios Jul 31, 2024
@joshualambert joshualambert merged commit 04956b7 into main Jul 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants