fix: Rename platform config iphone to ios
#669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
changed the title
iphone to ios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ti buildwithout any args, it would prompt for the platform, but then it wouldn't properly load the platform config because the property was calllediphone, yet the prompt value for iOS wasios(derived fromti.targetPlatformsinnode-titanium-sdk).The second problem is the prompted platform value was not being stored back into Commander. The platform prompt happens during the first parse. When calling Commander to re-parse with the new knowledge, it would think
--platformwas not set and then overwrite the previously prompted platform withundefinedcausing platform to be prompted again.