Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds coverage to mutable state builder #6388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidporter-id-au
Copy link
Contributor

@davidporter-id-au davidporter-id-au commented Oct 22, 2024

What changed?
Adds further tests to mutable state builder. Specifically the startTransactionHandleDecisionFailover() method which is used in determining what to do with decision tasks during a failover and when loading up the mutable state for a workflow.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@@ -1365,10 +1366,6 @@ func (e *mutableStateBuilder) GetTransferTasks() []persistence.Task {
return e.insertTransferTasks
}

func (e *mutableStateBuilder) GetCrossClusterTasks() []persistence.Task {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dead code

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31%. Comparing base (719eb07) to head (fc2bb19).
Report is 8 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/history/execution/mutable_state_builder.go 66.73% <ø> (+6.13%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719eb07...fc2bb19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants