Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for batcher workflow #6428

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sankari165
Copy link
Contributor

What changed?
unit tests for batcher workflow code

Why?
improve testing

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (3ee0a10) to head (b324bb8).
Report is 10 commits behind head on master.

Additional details and impacted files

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee0a10...b324bb8. Read the comment docs.

}

func TestWorkflowSuite(t *testing.T) {
suite.Run(t, new(workflowSuite))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: where possible I'd suggest moving away from the suite, since it can be fairly hard to track down or refactor changes to test data (among other things) and is obviated by most table-testing, but where we're extending existing code it totally makes sense to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants