Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin_db_clean_cmd test Part II #6437

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Oct 28, 2024

What changed?

  • Add more tests for admin_db_clean_cmd
  • Refactored initializeInvariantManager into ManagerFactory as well, since it is inside of fixExeuction. Increased testability
  • Renamed PersistenceManagerFactory to be ManagerFactory since initializeInvariantManager is not a persistence manager.

Why?
code coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 52.50000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (5b096d1) to head (aa27130).

Files with missing lines Patch % Lines
tools/cli/database.go 0.00% 8 Missing ⚠️
tools/cli/app.go 45.45% 4 Missing and 2 partials ⚠️
tools/cli/admin_db_scan_command.go 0.00% 2 Missing ⚠️
tools/cli/admin_commands.go 0.00% 1 Missing ⚠️
tools/cli/admin_db_clean_command.go 94.11% 1 Missing ⚠️
tools/cli/admin_timers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/admin_commands.go 10.62% <0.00%> (ø)
tools/cli/admin_db_clean_command.go 85.98% <94.11%> (+56.38%) ⬆️
tools/cli/admin_timers.go 0.00% <0.00%> (ø)
tools/cli/admin_db_scan_command.go 0.00% <0.00%> (ø)
tools/cli/app.go 91.24% <45.45%> (-2.48%) ⬇️
tools/cli/database.go 36.73% <0.00%> (-0.26%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b096d1...aa27130. Read the comment docs.

@bowenxia bowenxia changed the title Admin db clean cmd test 01 Admin db clean cmd test Part II Oct 30, 2024
@bowenxia bowenxia changed the title Admin db clean cmd test Part II admin_db_clean_cmd test Part II Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant