test: ✅ add a require + context module test case #12436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough本次更新引入了一个新的 CSS 文件 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Size Change: 0 B Total Size: 9.9 MB ℹ️ View Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/preset-umi/fixtures/prepare-build/normal/context2/umi.pngis excluded by!**/*.png
Files selected for processing (3)
- packages/preset-umi/fixtures/prepare-build/normal/context2/css.css (1 hunks)
- packages/preset-umi/fixtures/prepare-build/normal/context2/index.ts (1 hunks)
- packages/preset-umi/fixtures/prepare-build/normal/index.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/preset-umi/fixtures/prepare-build/normal/context2/css.css
Additional comments not posted (1)
packages/preset-umi/fixtures/prepare-build/normal/index.ts (1)
12-12: 引入和使用loadByRequire函数看起来没有问题。请确保在其他相关文件中也正确处理了这个新函数的引用。Also applies to: 18-18
Verification successful
引入和使用
loadByRequire函数看起来没有问题。请确保在其他相关文件中也正确处理了这个新函数的引用。
packages/preset-umi/fixtures/prepare-build/normal/index.ts:
import { loadByRequire } from './context2/';console.log(loadByRequire);packages/preset-umi/fixtures/prepare-build/normal/context2/index.ts:
export function loadByRequire(f: string): any {Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `loadByRequire` match the new usage. # Test: Search for the function usage. Expect: Only occurances of the new usage. rg --type typescript $'loadByRequire'Length of output: 71
Script:
#!/bin/bash # Description: Verify all function calls to `loadByRequire` match the new usage. # Test: Search for the function usage. Expect: Only occurrences of the new usage. rg --type ts 'loadByRequire'Length of output: 335
sorrycc
approved these changes
Jun 5, 2024
|
冲突了，merge 下 master。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.
Summary by CodeRabbit
.red，将文本颜色设置为红色。