Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modals await network requests #253

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

e-wai
Copy link
Contributor

@e-wai e-wai commented Jan 15, 2023

Think we're running into the problem that the user can submit multiple mutations since the UI hangs while waiting for a network response (without telling the user what's happening). We can either show a loading state or just close the modal and rely on the toasts to deliver the result. The first one has the advantage that it's easier to re-do an action, but if we're confident in actions succeeding more often than not, I think the second is a smoother experience.

Thoughts?

[Still a WIP, there's probably other blocking UI examples in the repo]

Notion ticket link

Ticket Name

Implementation description

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@e-wai e-wai temporarily deployed to fon-preview January 15, 2023 20:13 — with GitHub Actions Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ed5bcc5):

https://focus-on-nature--pr253-emma-fix-modal-await-g80qbr9x.web.app

(expires Sun, 22 Jan 2023 20:17:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0aeb3dd1cc2aa82265739c366a8befd0d956fd1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant