Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make default test parameters unique #183

Merged
merged 1 commit into from
Aug 1, 2023
Merged

make default test parameters unique #183

merged 1 commit into from
Aug 1, 2023

Conversation

laDok8
Copy link
Collaborator

@laDok8 laDok8 commented Apr 19, 2023

Closes #154
make default test parameters for azure-group and injected instances unique via maven timestamp

@laDok8 laDok8 requested a review from istraka April 19, 2023 09:51
istraka
istraka requested changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@istraka istraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two minor issues.

pom.xml Outdated Show resolved Hide resolved
aws-wildfly/src/test/java/aws/cloudformation/AwsTestConstants.java Outdated Show resolved Hide resolved
@laDok8 laDok8 requested a review from istraka April 27, 2023 07:39
istraka
istraka requested changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@istraka istraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I would just rearange properties.

aws-wildfly/pom.xml Outdated Show resolved Hide resolved
aws-wildfly/pom.xml Outdated Show resolved Hide resolved
@laDok8 laDok8 force-pushed the simultaneous_exec branch 6 times, most recently from 36feeaf to 2ae5c33 Compare May 29, 2023 14:07
@laDok8 laDok8 force-pushed the simultaneous_exec branch 3 times, most recently from 1103de4 to 48e4faf Compare May 30, 2023 08:50
@laDok8 laDok8 requested a review from istraka May 30, 2023 09:03
istraka
istraka requested changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@istraka istraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we need to have azure test run in separate groups. If you end up with fields with same annotation, feel free to remove them.

aws-wildfly/src/test/resources/sunstone.properties Show resolved Hide resolved
azure-wildfly/src/test/resources/sunstone.properties Outdated Show resolved Hide resolved
azure/src/test/java/sunstone/azure/armTemplates/MultipleAzArmTemplatesRepetableTest.java Outdated Show resolved Hide resolved
azure/src/test/java/sunstone/azure/armTemplates/suite/tests/PerSuitePerClassAzArmTemplates.java Outdated Show resolved Hide resolved
azure/src/test/resources/sunstone.properties Outdated Show resolved Hide resolved
@laDok8 laDok8 force-pushed the simultaneous_exec branch 3 times, most recently from 824a9d9 to a878b99 Compare May 31, 2023 12:14
@laDok8 laDok8 requested a review from istraka May 31, 2023 12:50
istraka
istraka requested changes Jun 19, 2023
View reviewed changes
azure/src/test/java/sunstone/azure/armTemplates/di/AzVmTests.java Outdated Show resolved Hide resolved
aws/src/test/java/aws/cloudformation/AwsTestConstants.java Outdated Show resolved Hide resolved
aws-wildfly/src/test/java/aws/cloudformation/AwsTestConstants.java Outdated Show resolved Hide resolved
azure/src/test/java/sunstone/azure/armTemplates/di/AzPgSqlTests.java Outdated Show resolved Hide resolved
...y/src/test/java/sunstone/azure/armTemplates/archiveDeploy/webapp/WebAppDeploySuiteTests.java Show resolved Hide resolved
.../azure/armTemplates/archiveDeploy/vmDomain/suitetests/AzureDomainVmUndeployedSecondTest.java Show resolved Hide resolved
...stone/azure/armTemplates/archiveDeploy/vmDomain/suitetests/AzureDomainVmDeployFirstTest.java Show resolved Hide resolved
...e-wildfly/src/test/java/sunstone/azure/armTemplates/archiveDeploy/vm/VmDeploySuiteTests.java Show resolved Hide resolved
.../sunstone/azure/armTemplates/archiveDeploy/webapp/suitetests/AzureWebAppDeployFirstTest.java Show resolved Hide resolved
...tone/azure/armTemplates/archiveDeploy/webapp/suitetests/AzureWebAppUndeployedSecondTest.java Outdated Show resolved Hide resolved
@laDok8 laDok8 requested a review from istraka June 20, 2023 10:20
istraka
istraka requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@istraka istraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few bits...

azure/src/test/java/sunstone/azure/armTemplates/di/AzureWebAppTests.java Show resolved Hide resolved
azure/src/test/java/sunstone/azure/armTemplates/di/AzVmTests.java Show resolved Hide resolved
azure/src/test/java/sunstone/azure/armTemplates/di/AzPgSqlTests.java Show resolved Hide resolved
@laDok8 laDok8 force-pushed the simultaneous_exec branch 2 times, most recently from 51b3c8d to c82817b Compare July 17, 2023 15:13
@laDok8 laDok8 requested a review from istraka July 17, 2023 15:15
@istraka istraka merged commit ab3420f into wildfly-extras:main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istraka istraka istraka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable simultaneous test execution
2 participants
@laDok8 @istraka