Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add WG_NODE_INTERNAL_URL #2

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix: add WG_NODE_INTERNAL_URL #2

merged 3 commits into from
Aug 30, 2023

Conversation

fiam
Copy link
Contributor

@fiam fiam commented Aug 18, 2023

No description provided.

@fiam
Copy link
Contributor Author

fiam commented Aug 30, 2023

@StarpTech I've tested this one. I had to change wunderctl is installed/invoked, I couldn't make it work via npm exec. It's working now.

@fiam
Copy link
Contributor Author

fiam commented Aug 30, 2023

Scratch that. It was failing because I tested it with an app that a node_modules managed by pnpm causing npm exec to fail. I've undone that part.

StarpTech
StarpTech approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiam fiam merged commit 8dd0447 into main Aug 30, 2023
1 check passed
@fiam fiam deleted the alberto/add-wg-node-internal-url branch August 30, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiam @StarpTech