Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit input to make it possible to use this action with third party PRs #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmsj
Copy link

@cmsj cmsj commented Jan 5, 2022

Closes #23

@cmsj
Copy link
Author

cmsj commented Jan 5, 2022

I'm kinda new to making GitHub Actions, so I'm not actually sure how I can test this (either locally or by publishing the action under a new name from my fork of this repo)

@cmsj
Copy link
Author

cmsj commented Jan 5, 2022

I figured out how to publish this as a test action, but it doesn't seem to work. I suspect that publishing the annotations on a commit ID in the target repo causes them to just not get associated with anything, and thus lost.

I would suggest not merging this PR until it can be reworked by someone who understands the GitHub APIs better than I :)

@ggrossetie
Copy link
Member

I suspect that publishing the annotations on a commit ID in the target repo causes them to just not get associated with anything, and thus lost.

Yes that's correct, the same thing happened to me while I was working on c707e6d.

I would suggest not merging this PR until it can be reworked by someone who understands the GitHub APIs better than I :)

I took a look at other GitHub Actions but so far I have yet to find a working solution 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override commit SHA
2 participants