Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: new option to include user-stylesheets as <style>-tags, rather referring them through <ref>-tags. #319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nifranz
Copy link

@nifranz nifranz commented May 12, 2023

The extension now supports an additional option, importStylesheetAsStyletag: if it set to true, the external user stylesheets added through vscode extension options are no longer merely referenced by a ref-tag, but rather their contents are included in <style>-tags so the html file doesn't break if the included stylesheets aren't present on the machine, thus improving shareability of the resulting html file.

GitHub somehow shows that the whole "extension.js" file changed while it was just a few changes, so below you'll find screenshots of the actual diff for convenience:

image image

The extension now supports an additional option, importStylesheetAsStyletag: if it set to true, the external user stylesheets added through vscode extension options are no longer merely referenced by a <ref>-tag, but rather their contents are included in <style>-tags so the html file doesn't break if the included stylesheets aren't present on the machine, thus improving shareability of the resulting html file.
@nifranz
Copy link
Author

nifranz commented May 12, 2023

looks like the complete file diff issue for "extensions.js" file is related to whitespace changes. Here's a quick diff view solution: https://stackoverflow.com/questions/37344280/git-diff-is-showing-full-file-has-changed-for-a-single-line-change-but-only-for/63062580#63062580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant