Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account_invoice_fixed_discount: Check base_line type #1614

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

tsliepen-ws
Copy link

hr_expense calls _convert_to_tax_base_line_dict with base_line set to None. Comparison of base_line._name in account_invoice_fixed_discount causes an attribute error.

Add extra check to ensure there is an account.move.line to check against in base_line.

hr_expense calls _convert_to_tax_base_line_dict with base_line set to None. Comparison of base_line._name in account_invoice_fixed_discount causes an attribute error.

Add extra check to ensure there is an account.move.line to check against in base_line.
Copy link

@PieterPaulussen PieterPaulussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link

CRogos commented Jan 5, 2024

@pedrobaeza could you merge this or my #1636 PR? (and close the other)
I saw this PR to late, but basically both PR are the same. (I added one unit test, but this PR has already reviewer.)

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 5, 2024
@pedrobaeza
Copy link
Member

/ocabot merge patch

@CRogos when this one is merged, you can rebase and add the test for better regression avoidings.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1614-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b5515e9 into OCA:16.0 Jan 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2fae541. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants