[16.0][IMP] account_invoice_fixed_discount: Error on create expense #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRogos
changed the title
CRogos
force-pushed
the
16-0-imp-account_invoice_fixed_discount
branch
from
c6f1cb8
to
62d5169
Compare
CRogos
force-pushed
the
16-0-imp-account_invoice_fixed_discount
branch
from
62d5169
to
ae43e41
Compare
|
Add unit test for #1614 |
pedrobaeza
approved these changes
Jan 5, 2024
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 28807e9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hr_expense is installed, base_line can be None:
https://github.com/odoo/odoo/blob/fa0a6b077b171473da950c969de9e25c3577058e/addons/hr_expense/models/hr_expense.py#L187