[Docs] Workflow output: Include publish in example.
#5274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5273 [ci-skip] Signed-off-by: Phil Ewels <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamrtalbot
reviewed
Sep 2, 2024
Comment on lines
410
to
415
| workflow { | ||
| foo(bar()) | ||
|
|
||
| publish: | ||
| foo.out >> 'foo' | ||
| } |
There was a problem hiding this comment.
Would it be better to remove fake details? This way draws your attention to the output block which is the focus of the statement.
Suggested change
| workflow { | |
| foo(bar()) | |
| publish: | |
| foo.out >> 'foo' | |
| } | |
| workflow { | |
| // ... | |
| } |
There was a problem hiding this comment.
Maybe, but having it there does implicitly tell anyone skim-reading just this one section that nothing is going to happen without publish, which I quite like..
|
I wouldn't bother with this, since this whole section will be re-vamped in the next month or two by #5185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5273
[ci-skip]