Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Workflow output: Include publish in example. #5274

Closed
wants to merge 1 commit into from
Closed

[Docs] Workflow output: Include publish in example. #5274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,9 @@ A script may define the set of outputs that should be published by the implicit
```groovy
workflow {
foo(bar())

publish:
foo.out >> 'foo'
}
Comment on lines 410 to 415
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to remove fake details? This way draws your attention to the output block which is the focus of the statement.

Suggested change
workflow {
foo(bar())
publish:
foo.out >> 'foo'
}
workflow {
// ...
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but having it there does implicitly tell anyone skim-reading just this one section that nothing is going to happen without publish, which I quite like..


output {
Expand Down
Loading